RaspberryPiFoundation / lesson_format

Lesson formatter
17 stars 28 forks source link

Right-to-left formatting bugs #186

Closed rikcross closed 5 months ago

rikcross commented 8 years ago

I think @andylolz mentioned previously that the rtl support was only tested for PDFs. I've added a couple of Hebrew projects, and the screenshot below shows a few formatting problems (mainly header/footer related).

screen shot 2016-03-07 at 15 53 08

martinpeck commented 8 years ago

FYI this is unlikely to get fixed because of #168

andylolz commented 8 years ago

Adding translations to the he-IL language file will probably might help a bit: https://github.com/CodeClub/lesson_format/blob/46e5128b/assets/languages/he-IL.language#L6-L8

Otherwise, you might possibly be able to add rtl: true to the frontmatter of project files, and remove it from the he-IL language file. Then the menus (which are currently largely in English) will at least remain left-to-right.

NB I haven’t looked into either of these things – they’re just guesses. If it’s likely a PR will be accepted on this, I would happily take a look.

rikcross commented 8 years ago

Hi Andy, we have volunteers writing projects in rtl languages at present, and so it might complicate things to ask them to add extra data to the frontmatter.

andylolz commented 8 years ago

it might complicate things to ask them to add extra data to the frontmatter

Yeah, fair enough. Well, this might help:

Adding translations to the he-IL language file will probably might help a bit: https://github.com/CodeClub/lesson_format/blob/46e5128b/assets/languages/he-IL.language#L6-L8

Otherwise, the fix would involve changes to lesson_format.

rikcross commented 8 years ago

@freyjaodds and I also spotted that the checkboxes are on the wrong side.

screen shot 2016-03-10 at 09 49 03