search

RaspberryPiFoundation / lesson_format

Lesson formatter
18 stars 28 forks source link

Empty first pages in some PDFs #59

Closed rikcross closed 9 years ago

rikcross commented 10 years ago

For example the 'Missing Cat Website' HTML project.

screen shot 2014-09-23 at 16 26 04

andylolz commented 10 years ago

Looks like the intro is a h2 here. According to this, it should always be a h1. I suspect that’s what’s causing the problem here (although I haven’t investigated why yet.)

andylolz commented 10 years ago

I suspect that’s what’s causing the problem here

UPDATE: It’s not. It’s the size of the screenshot in the intro. There’s a max-width, but not a max-height, and the lost cat image here is portrait and quite tall.

Setting a sensible max-height fixes this.

andylolz commented 10 years ago

Hopefully fixed now.

andylolz commented 9 years ago

Assigning @CodeClubRik to check.

rikcross commented 9 years ago

Checked :) Thank you, you're a legend.