[Refactoring] WindowService/BrightWindow - Githubissues

Rastopyr / bright

"bright 🌓" is macOs app for control brightness for native and external displays

MIT License

3 stars 0 forks source link

[Refactoring] WindowService/BrightWindow #8

Closed Rastopyr closed 3 years ago

Rastopyr commented 4 years ago

Definition

For now, the window is spawned with the SwiftUI component. It could be a problem in the future to control it.

Solution

WindowService should be refactored, and support maintaining of windows.

AC

[x] We should create any number of windows, styled by StyleGuide
[x] We should update the size and position of any window
[x] We should show/hide any window
[x] We should show the close button on any window
[ ] ~~We should animate size of any window~~

Rastopyr commented 3 years ago

Example window built with new service

Screenshot 2020-09-30 at 12 04 01 PM

Rastopyr commented 3 years ago

Example window with SwiftUI view

Screenshot 2020-09-30 at 12 15 35 PM

Rastopyr commented 3 years ago

Screenshot 2020-09-30 at 3 59 16 PM

Window without close button

Rastopyr commented 3 years ago

Close this issue as completed. Criteria about animation will be implemented in next stories

Rastopyr commented 3 years ago

Screenshot 2020-09-30 at 8 03 16 PM

Both windows implemented correctly in 775766b commit