search

RatInABox-Lab / RatInABox

A python package for simulating 2D motion in continuous environment and spatial cell types (e.g. place cell).
MIT License
184 stars 31 forks source link

Small bug relating to PR #101 #102

Closed TomGeorge1234 closed 7 months ago

TomGeorge1234 commented 8 months ago

@colleenjg relating to PR #101

Sorry! After giving it the all clear I ran the tests and spotted an extra warning. If I just initialise a population of BVCs

Env = Environment()
Ag = Agent(Env)
BVCs = BoundaryVectorCells(Ag,params={'n':11})

it warns

UserWarning: Ignoring 'n' parameter value (11) that was passed, and setting number of BoundaryVectorCells neurons to 11, inferred from the cell arrangement parameter.

Sorry, I can dig into this in the morning but it might be quicker for you to solve.

colleenjg commented 8 months ago

Oh yes! That's because I was relying on the non-equality to raise the warning. I removed it quickly after our discussion without realizing that the decision to create the warning fully depends on it. And I didn't rerun my test code 😬

I'll fix it! Thanks for noticing it!