Closed colleenjg closed 3 months ago
Minor edit: I hadn't pulled the latest version. The error is still present, but the exact values for both MAX_FR
values are 0.0000 to 1.0088
.
Oh yes I see that is a bit of a bug, it totally cancels itself out. Not sure how I'd missed that/when it crept in. I'll take a look at your PR and leave this open until it's solved
I noticed that the BVC firingrates weren't scaling correctly if
max_fr
is not 1. I've traced the source of the issue toself.cell_fr_norm
. This value is initialized based on scaled firingrates, but then applied before scaling when callingget_state()
, and thus cancels out the subsequent scaling. See L1543 and L1679 ofNeurons.py
gives
0.0000 to 1.0165
(FYI: you can see there's a slight overshoot of the max, which might be for another issue.)But, if you set
MAX_FR = 10
, you still get0.0000 to 1.0165
.I'll create a PR in a moment to propose a solution.