Closed colleenjg closed 1 year ago
Great bug fix. Thanks!
tbh I'd probably vote to leave the .gitignore
out to not clutter the repo.
Re. the bug fix its totally fine as it is and I'll accept it. These are totally nit-picks but optionally if you wanted to you could use: self.Agent.Environment.dimensionality == '1D'
or 2D
rather than data shape to test for whether its 1D (maybe more readable). Also just a comment saying what this does.
Thanks again :))
Made the edits, removing the .gitignore and checking directly for the environment dimensionality!
Added a
.gitignore
, to automatically ignore cache files. Fixed a bug inPlaceCells.plot_place_cell_locations()
: it was assuming that place cell centres were 2D, and breaking for a 1D environment.