RatInABox-Lab / RatInABox

A python package for modelling locomotion in complex environments and spatially/velocity selective cell activity.
MIT License
175 stars 31 forks source link

FieldOfViewNeurons structuring #56

Closed TomGeorge1234 closed 1 year ago

TomGeorge1234 commented 1 year ago

FieldOfViewNeurons are structured poorly with the super class being Neurons when it should really be ObjectVectorCells or BoundaryVectorCells. This current work around is that the OVCs or BVCS a stored as an attribute called (cheekily) super. This is bad and should be update to the following:

FieldOfViewNeurons is a parent class. The manifold display function etc. should live in here. FieldOfViewOVCs and FieldOfViewBVCs are. child classes.

TomGeorge1234 commented 1 year ago

discussion move to #71