search

RatInABox-Lab / RatInABox

A python package for modelling locomotion in complex environments and spatially/velocity selective cell activity.
MIT License
175 stars 31 forks source link

major refactoring #58

Closed mehulrastogi closed 1 year ago

mehulrastogi commented 1 year ago

This PR is in regards to the https://github.com/TomGeorge1234/RatInABox/issues/55

mehulrastogi commented 1 year ago

This needs additional testing to verify the imports

Will also include a requirements.txt

mehulrastogi commented 1 year ago

Closes #55

TomGeorge1234 commented 1 year ago

Gonna shelve this for now. It does need to be done but I think it will require a bit of thought from my end (updating all the demos etc.) and I don't have the time rn. It's not exactly going to be backwards compatible so I'm thinking of combining it with a bunch of other updates later down the line, maybe a RiaB2.0.

Happy to reconsider and/or chat once I'm more free in July.

mehulrastogi commented 1 year ago

Yes, backward compatibility is an issue with this kind of significant refactoring...i guess its better to have it in a major release but maybe start a branch for it so that the new developments can use the new package structure.

I did solve the imports in the demos but yes more testing is needed

TomGeorge1234 commented 1 year ago

Ok, reopened, I just made a new branch called v2_beta

TomGeorge1234 commented 1 year ago

Ok I merged it into v2_beta branch.