search

RatInABox-Lab / RatInABox

A python package for simulating 2D motion in continuous environment and spatial cell types (e.g. place cell).
MIT License
184 stars 31 forks source link

flexible head direction #72

Closed mehulrastogi closed 1 year ago

mehulrastogi commented 1 year ago

solves #70

TomGeorge1234 commented 1 year ago

brilliant, I made a couple of minor tweaks; some warnings plus I think the head direction vector should be updated with the normalised velocity vector rather than straight-up velocity so its not biased in favour of faster speeds, thats all.

great job @mehulrastogi, thanks for a speedy update!

mehulrastogi commented 1 year ago

@TomGeorge1234 there is a typo in the last commit. Instead of warning.warn it should be warnings.warn

We should really set up the automatic tests. Want me to look into it?

TomGeorge1234 commented 1 year ago

fixed. but you're right, this shouldn't happen, tests would be great actually, if you had time I'd really appreciate it!