search

RatanShreshtha / DeepThought

A simple blog theme focused on writing powered by Bulma and Zola.
https://deepthought-theme.netlify.app/
MIT License
177 stars 92 forks source link

feat: add multilingual navbar #13

Closed Guileas closed 3 years ago

Guileas commented 3 years ago

Fixes: https://github.com/RatanShreshtha/DeepThought/issues/11

RatanShreshtha commented 3 years ago

@Guileas Add few screenshots as well, rest all looks good to me.

Guileas commented 3 years ago

@RatanShreshtha I've modified my PR to fix some issues I had for multiple translations and add navbar screenshoots as you suggested. I had to add the language code to the navbar_items array to make everything work but no more default navbar if the user add a language code and forgot to add a translation in the navbar_items array for this language. I also don't really know how to fix all the check, the lang variable is not something I can control so let me know what I can do to fix that

RatanShreshtha commented 3 years ago

@Guileas Thanks