Avatar variable is required for 404 template, but not for index template

TheGhostHuCodes commented 3 years ago

Hi, thanks for your work on this great looking zola theme!

When I was setting up my blog without an avatar, I noticed that in the index.html template it is not required. https://github.com/RatanShreshtha/DeepThought/blob/master/templates/index.html#L7-L11

But for the 404.html template it is required, and this breaks the static site build. https://github.com/RatanShreshtha/DeepThought/blob/master/templates/404.html#L8-L10

Should we surround the 404 avatar image with a

{% if config.extra.author.avatar %}
...
{% endif %}

block?

RatanShreshtha commented 3 years ago

Thanks @TheGhostHuCodes for making me aware of it.

TheGhostHuCodes commented 3 years ago

@RatanShreshtha, do you take PRs for this repo? If so I'd be happy to make this fix.

RatanShreshtha commented 3 years ago

I fixed it recently and in future feel free to open PR for improvements :thumbsup: . Let me also add contribution guide as well for the repo.

TheGhostHuCodes commented 3 years ago

Fixed in 46642aa

RatanShreshtha / DeepThought