search

RatanShreshtha / DeepThought

A simple blog theme focused on writing powered by Bulma and Zola.
https://deepthought-theme.netlify.app/
MIT License
176 stars 92 forks source link

Footer block is gone #39

Closed hadilq closed 2 years ago

hadilq commented 2 years ago

Hey @RatanShreshtha, thank you for your great work here. I really appreciate it and it's a while that I am using it in my blog! However, today I pulled the last changes of this theme, where I noticed the footer block is not where it was before! It removed in this commit. 

Fix 404 page 
@@ -173,7 +165,6 @@
  {% block comment %}
  {% endblock %}

-  {% block footbar %}
  <footer class="footer py-4">
    <div class="content has-text-centered">
      <p>
@@ -203,7 +194,6 @@

Is it intended or a mistake?

RatanShreshtha commented 2 years ago

This is intended as the 404.html page is inheriting from base.html

hadilq commented 2 years ago

Thank you for your answer, but would you explain more? What will happen if someone change the footer in 404 page?

SkypLabs commented 2 years ago

Hi @RatanShreshtha,

I don't see the link between the footer block and the 404 page either.

Could you please elaborate more on this?

Thanks.

SkypLabs commented 2 years ago

@hadilq Footer block is back! https://github.com/RatanShreshtha/DeepThought/pull/67