search

RatanShreshtha / DeepThought

A simple blog theme focused on writing powered by Bulma and Zola.
https://deepthought-theme.netlify.app/
MIT License
176 stars 92 forks source link

Add basic Plausible support #53

Closed ProfHercules closed 2 years ago

dlecan commented 2 years ago

@RatanShreshtha instead of having multiple analytics blocks in base (and so many tools to integrate :grin:), would you be interested in a generic block to be overloaded? Like this one https://github.com/dlecan/dlecan-zola-theme/blob/main/templates/base.html#L49-L61

GA would stay the default analytics tool, but anyone would replace it by its own tool simply by overloding a Zola block

What do you think of this proposal @ProfHercules?

ProfHercules commented 2 years ago

I like the flexibility provided by the generic block, but I also enjoy the simplicity of just modifying a config value.

I'm not sure a use case exists for it, but using the config value also allows the theme to support multiple concurrent analytics systems simultaneously (maybe you prefer GA, but if a user blocks it you would still like some general stats from Plausible?).

A generic block is likely the right solution here - it enables the theme to support a default config and allows the user to override if they wish.

Would you open the PR for this suggestion @dlecan? If so, I'll happily close this issue.

dlecan commented 2 years ago

Would you open the PR for this suggestion @dlecan?

See #55

ProfHercules commented 2 years ago

Closing in favour of #55