search

RatanShreshtha / DeepThought

A simple blog theme focused on writing powered by Bulma and Zola.
https://deepthought-theme.netlify.app/
MIT License
178 stars 91 forks source link

Adding social option: Signal #77

Closed arichtman closed 1 year ago

arichtman commented 1 year ago

Signal is a popular secured messaging protocol. This PR adds socials support for Signal. I have tested with and without a value in config.toml and the icon does toggle. The URL is valid, though I note that the icon is not an official one for the brand, I had to make do with what was available on FontAwesome. The phone number in the config is randomly generated and should not be valid. Feel free to adjust this as you like.

Regards and thanks,

RatanShreshtha commented 1 year ago

I am uncertain if you should add apps meant for personal communication in portfolio themes, you might end up with a barrage of spams.

SkypLabs commented 1 year ago

I am uncertain if you should add apps meant for personal communication in portfolio themes, you might end up with a barrage of spams.

For your information, Signal is not only used for personal communication. Lots of journalists use it with a public work phone number for example.

arichtman commented 1 year ago

I have a dedicated work number for it too But I don't take the rejection to heart :)