Closed dvisztempacct closed 6 years ago
To see the old tests break, just add another exception type to your project. It's probably pretty likely to break the tests.
Thanks for the PR. On further thought, shouldn't we be testing JavaScript exceptions? I believe TestError
is an ocaml exception, which has a different runtime representation.
@gilbert yes I think that would be a good idea. Once this is merged I'm going to write some
Sounds good. Thank you for you contribution!
when you use
Js.String.make()
as your error transformer, i'm guessing that maps to javascripts'String()
function, which means you'll get a string based on the specific JS representation that bucklescript has chosen for your error value.these changes should work no matter how
bsb
decides to represent those values