RationalJS / future

A Js.Promise alternative for ReasonML
214 stars 15 forks source link

Implement FutureJs.toPromise #25

Closed seprich closed 5 years ago

seprich commented 5 years ago

Even if conversion from (js)Promise to Future is often sufficient on the assumption that all following computation is done within the Future monad, it is still sometimes necessary to convert Future back to Promise. E.g. When writing aws lambdas the ultimate return value must be a promise.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 38


Totals Coverage Status
Change from base Build 34: 1.5%
Covered Lines: 107
Relevant Lines: 121

💛 - Coveralls
gilbert commented 5 years ago

This looks great. Can you do a quick rebase? I think there's a small redundancy in the test file now.

MoOx commented 5 years ago

Any plan to ship this in a release? =)

gilbert commented 5 years ago

Done!