search

RationalJS / future

A Js.Promise alternative for ReasonML
214 stars 15 forks source link

Add all part deux #32

Closed johnhaley81 closed 5 years ago

johnhaley81 commented 5 years ago

An alternative PR to #22

Depends on #31

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 53

Files with Coverage Reduction New Missed Lines %
src/Future.bs.js 12 85.38%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 51: 0.9%
Covered Lines: 119
Relevant Lines: 133
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 53

Files with Coverage Reduction New Missed Lines %
src/Future.bs.js 12 85.38%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 51: 0.9%
Covered Lines: 119
Relevant Lines: 133
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 53

Files with Coverage Reduction New Missed Lines %
src/Future.bs.js 12 85.38%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 51: 0.9%
Covered Lines: 119
Relevant Lines: 133
💛 - Coveralls
sikanhe commented 5 years ago

Any reason why this hasn't been added?

gilbert commented 5 years ago

I don't work with reasonml at the moment and haven't for a while. Does anyone want to become a maintainer?

briangorman commented 5 years ago

@gilbert I can help maintain this project

gilbert commented 5 years ago

@briangorman Invite sent

briangorman commented 5 years ago

@gilbert I reached out to you on your gitter about how to best proceed! Thanks