search

RationalJS / future

A Js.Promise alternative for ReasonML
214 stars 15 forks source link

Resolve #4 FutureJs.fromPromise #6

Closed scull7 closed 6 years ago

scull7 commented 6 years ago

I decided to remove the Js.String.make call from the internal implementation and pass the raw Js.Promise.error object to the errorTransformer user provided function. I believe this way is the least intrusive way of allowing the caller to implement the error calling pattern.

gilbert commented 6 years ago

Perfect, thank you. And the build passes! 🎉