Ratismal / UNO

An uno discord bot
69 stars 35 forks source link

Auto-kick Timer Doesn't Work #10

Closed Willard21 closed 6 years ago

Willard21 commented 6 years ago

Checklist

Expected Behavior

The game should be deleted if it doesn't start within a few minutes, and it should kick players that don't take their turn within a certain time (including the host).

Current Behavior

Players can start a game and never end it, or even leave the server, and the channel can never again play Uno.

Steps to Reproduce (for bugs)

  1. Start game
  2. Do nothing

Context

This has been causing problems on the Discord Dungeons server (currently Spookord Dungeons for October). Multiple uno channels have been deleted or locked because of it. I know there's code in the bot to handle this situation, but it never runs.

schrmh commented 6 years ago

If you clone the code from GitHub and run it a game will end after one minute per default in case that no one joins. The public inviteable bot differs from that.

Willard21 commented 6 years ago

Well the problem has existed for a few months now. Has it not been updated in that long? Selfhosting doesn't sound like a very appealing solution.

Ratismal commented 6 years ago

Isolated the issue. It was caused by the bot trying to send a "your game has timed out" message to a channel that it no longer had access to, causing the rest of the game timeouts to never be called. This should be fixed now.