RatkoR / laravel-crate.io

Crate.io driver for Laravel
MIT License
36 stars 12 forks source link

feat: add partitioningBy and generated Columns #34

Closed JulianMar closed 4 years ago

JulianMar commented 4 years ago

Table creation syntax now includes table partitioning see. https://crate.io/docs/crate/reference/en/latest/general/ddl/partitioned-tables.html Generated columns can be created via a migration https://crate.io/docs/crate/reference/en/latest/general/ddl/generated-columns.html#sql-ddl-generated-columns

RatkoR commented 4 years ago

Great!

I used your partitioning branch in our internal project and it works ok and it also passes all tests. I can confirm that it doesn't break any existing code (at least for us).

We'll not be using partitions yet, so I'll merge it if you say you're ok and that it works for you.

JulianMar commented 4 years ago

Thank you for taking a look!
Yeah you are right I made a typo there, but I fixed it now :)