search

RatkoR / laravel-crate.io

Crate.io driver for Laravel
MIT License
36 stars 12 forks source link

feat: update to laravel 9 #43

Closed JulianMar closed 2 years ago

JulianMar commented 2 years ago

All tests on our Codebase worked as expected. Same for the tests in this repo.
I made it a bit easier to test by using the run-tests.sh script. It starts a crate instance and destroys it after testing. I override the migration for the migration table aswell. This way it's easier to contribute

Support for some older laravel version got dropped, because laravel 9 requires php 8.0.2

Would be awesome to get this PR checked and tested in your codebase!

RatkoR commented 2 years ago

Hi!

Sure, I'll check and merge it. We're stuck with older laravel - I'll see if our internal tests still work...

JulianMar commented 2 years ago

That would be awesome! Thank you

RatkoR commented 2 years ago

I had problems with setting up our tests on newer laravel. So then I just copied models, routes and some other stuff into fresh laravel installation and checked manually. It's not as many tests as before, but the ones I did were all ok. I tested with laravel 9 and laravel 8.

So having these basic CRUD tests pass and because all laravel-crate.io tests pass also, I'm fine with merging.

I'll update README.md and increment tag to v12.

Thank you @JulianMar

RatkoR commented 2 years ago

I had problems with setting up our tests on newer laravel. So then I just copied models, routes and some other stuff into fresh laravel installation and checked manually. It's not as many tests as before, but the ones I did were all ok. I tested with laravel 9 and laravel 8.

So having these basic CRUD tests pass and because all laravel-crate.io tests pass also, I'm fine with merging.

I'll update README.md and increment tag to v11.

Thank you @JulianMar