search

Rattlehead15 / tachiyomiOCR

Tachiyomi fork which adds OCR and dictionary lookup capabilities for the purpose of language learning.
https://tachiyomi.org/
Apache License 2.0
85 stars 7 forks source link

[Meta] Disable ACRA crash reports to main Tachiyomi crash reporting endpoint #2

Closed arkon closed 3 years ago

arkon commented 3 years ago

Hi there,

Nice work with your fork!

I've started noticing crash reports in our system originating from your fork. Can you either disable ACRA or point it to a different instance?

cf. https://github.com/Rattlehead15/tachiyomiOCR/blob/master/app/src/main/java/eu/kanade/tachiyomi/App.kt#L31

Rattlehead15 commented 3 years ago

Hey, I'm glad you liked it! Sorry for that, it's the first time I've forked an android app and I'm not really sure what needs to be changed. I'll be fixing this as soon as possible, is there any other thing that I should modify so as to not bother you guys anymore?

arkon commented 3 years ago

Good question. I've compiled a list of things that should be changed here: https://github.com/tachiyomiorg/tachiyomi/blob/master/CONTRIBUTING.md#forks

Rattlehead15 commented 3 years ago

Sorry, but do I really have to change the package name or can I just change the applicationId? I'm asking because changing the package name seems to break the installing of extensions since it can't find some classes

arkon commented 3 years ago

Sorry, yes I meant the applicationId. However, it'll affect your existing installations.

Rattlehead15 commented 3 years ago

Alright I think it's all done now, except for the icon which I'll have to spend some time on. Thanks for taking the time to make the checklist. Also, it's possible some people won't see this update and will keep sending crash reports so really sorry for that.

arkon commented 3 years ago

Your changes look good, but make sure to disable or change the ACRA endpoint too.

Rattlehead15 commented 3 years ago

oh my bad I forgot to disable it