search

RaulBejarano / Ultimate-Toroidal-Propeller-Generator

The Ultimate Toroidal Propeller Generator is an open source project that provides a way to generate STL files of toroidal drone propellers.
GNU General Public License v3.0
110 stars 17 forks source link

Missing method call to actually build the thing #18

Closed fj-ar closed 11 months ago

fj-ar commented 12 months ago

Missing toroidal_propeller(); in the end of the file.

RaulBejarano commented 11 months ago

Hello @fj-ar. Thank you for your interest in the project. At first the file "src/toroidal_propeller.scad" is intended to be a simple library to import into the designer's scad. Do you think it would simplify the use of the project to include the module call in the toroidal_propeller.scad file? If so, I invite you to include it yourself and make a pull request so that you appear as a contributor

Little-Night-Wolf commented 11 months ago

I've made the pull request by adding the "toroidal helix();" and other things that I find interesting

fj-ar commented 11 months ago

I used scad for the first time in my life, as probably many others will who stumble upon this project. So I think it would make sense to include the execution in the script!