search

Raureif / sketch-click-dummy

Sketch Click Dummy Plugin
MIT License
105 stars 15 forks source link

Create Export Click Dummy@2X Center.sketchplugin #11

Closed technotablet closed 7 years ago

technotablet commented 9 years ago

It enables export to 2X resolution (retina display on Macbook Pro for example), and also center aligns the prototype giving a better visual feel.

technotablet commented 9 years ago

I was wondering if you were able to have a look at it. I am using it for my own projects and it is working very well. The code written by you has been changed in a minor way to enable 2X export which look great on a retina display, along with center aligning. If you feel, we can do it for the regular version as well.

Looking forward to your response. Thank you.

Raureif commented 9 years ago

Thanks for your work on the plugin and sorry for not getting back to you sooner.

I am not merging your change because having second script (that almost does the same thing) duplicates too much code. You can see the issues already; the onclick change you made exist only in your 2x version of the export code. The code would need refactoring to prevent excessive code duplication before I can pull the changes. I hope you see this point. Thanks!