search

Rav3nPL / p2pool-rav

Peer-to-peer Bitcoin mining pool
http://bitcointalk.org/index.php?topic=18313
GNU General Public License v3.0
58 stars 66 forks source link

Auto worker diff #64

Closed Rav3nPL closed 10 years ago

roy7 commented 10 years ago

Awesome! Thanks.

roy7 commented 10 years ago

default=1.0 for minimum difficulty is correct for BTC miners, but will be far too high for scrypt miners, FYI. I let iongchun know as well.

coli commented 10 years ago

What are the purpose of these switches?

roy7 commented 10 years ago

@iongchun I added my comments because I directed someone to your branch for their scrypt coin node since they wanted to better control psuedo share difficulty. They did use --min-difficulty 0.00001526 but the rounding code (I think it was?) kept changing it back to a minimum diff of 1. So the conversion has to be present in there somewhere apparently? Or maybe should the rounding code be ignored on non-sha256 coins? That's easy enough to check if DUMB_SCRYPT_DIFF is 1 or not. I'm not sure of the reason for the rounding (do some miners only accept power of 2 work targets?) or if it's just cosmetic.

roy7 commented 10 years ago

@iongchun Or perhaps make rounding optional via command line argument.

iongchun commented 10 years ago
  1. Min diff kept back to 1 should be fixed in 9792f8b72e4bdce3f297a86738a7d5b75e6cd2fe;
  2. My auto-worker-diff branch now accepts coin-specified difficulty (modified by DUMB_SCRYPT_DIFF), so "--min-difficulty 0.00001526" is not needed any more.