search

RaveJS / rave

Zero-configuration application bootstrap and development
278 stars 8 forks source link

Rave gives cryptic errors for missing modules ("fs" and "traceur") when app's moduleType is missing #56

Closed unscriptable closed 10 years ago

unscriptable commented 10 years ago

If the user doesn't specify a moduleType in the top-level bower.json file, rave gets loaded twice and ends up spewing cryptic error messages about not being able to load "fs" and "traceur". This happened once before and seems to be a regression.

KidkArolis commented 10 years ago

I thought that was fixed by adding cjs module type detection. In other words some moduleType is always detected and this error shouldn't be shown. How do you reproduce this issue? On Jul 24, 2014 9:27 PM, "John Hann" notifications@github.com wrote:

If the user doesn't specify a moduleType in the top-level bower.json file, rave gets loaded twice and ends up spewing cryptic error messages about not being able to load "fs" and "traceur". This happened once before and seems to be a regression.

— Reply to this email directly or view it on GitHub https://github.com/RaveJS/rave/issues/56.

unscriptable commented 10 years ago

This is easy to reproduce. Just clone and install rave-start as per the directions, then remove the moduleType property from bower.json.

I agree that moduleType detection is the way to go, but this problem is getting in the way! :)

unscriptable commented 10 years ago

Fixed as of 0.3.0! \o/