search

Raven24 / diaspora-federation

MIT License
18 stars 5 forks source link

Required and optional properties #2

Closed jhass closed 11 years ago

jhass commented 11 years ago

First rough attempt, please review.

Raven24 commented 11 years ago

good thing the DSL got introduced early... makes adding stuff so much nicer :P

do you have an idea why travis says that rspec is missing?

jhass commented 11 years ago

Yes, because of my stupidity :P Should be fixed.

coveralls commented 11 years ago

Coverage Status

Coverage increased (+0.02%) when pulling de305100827ccdce6cdeb1bc0c74d9987fda0c3c on MrZYX:required_and_optional_properties into 04ae84a0922af630835cd53ed9e6f2aadf0c5468 on Raven24:master.

coveralls commented 11 years ago

Coverage Status

Coverage increased (+0.02%) when pulling 14ab44444658a9a2261c7c7c75b4395cfdbc04b9 on MrZYX:required_and_optional_properties into 04ae84a0922af630835cd53ed9e6f2aadf0c5468 on Raven24:master.

Raven24 commented 11 years ago

alright, I think this should be good to go :)

I'll be on a ruby user group meeting next week, where I'll have the opportunity to let people review the gem some more. let's see if they have some opinions to improve this some more ^^