search

RavenProject / Ravencoin

Ravencoin Core integration/staging tree
https://www.ravencoin.org
MIT License
1.08k stars 671 forks source link

gui: Add 'Watch Only' Support for Asset Balances #1150

Open m4r1m0 opened 2 years ago

m4r1m0 commented 2 years ago

Running on Ubuntu 20.04 using raven-4.7.0test3-b5010492c (64 bit).

Testing P2SH for Assets and discovered that assets sent to a P2SH address will not display in your 'Watch only' list.

RVN balances display correctly in a separate column for P2SH addresses.

I suggest adding Asset Balances to the 'Watch only' list in a separate column from spendable wallet balances.

watchonly2 Above you can see my transaction list with various asset and RVN transaction to P2SH address '2NG5F15LVeYtyKmTeQ44HTrkY5iSLZTKrvB' which has been added to 'Watch only' via the importaddress command.

watchonly1 And here you can see my wallet balances page. Notice that RVN balances are displaying correctly whereas Asset Balances remains blank despite multiple transfers of "KINKAJOUCOIN" to P2SH address '2NG5F15LVeYtyKmTeQ44HTrkY5iSLZTKrvB'.

m4r1m0 commented 2 years ago

Title changed because further testing reveals there is no 'Watch only' functionality for Asset Balances of P2PKH addresses either.

Suggest that this feature be added for all supported address types.

lsji07 commented 2 years ago

The way I understand adding a P2SH address to watch was via importmulti with the relevant P2PK addresses involved. Not tested if this works but that would be the behaviour I would expect.

m4r1m0 commented 2 years ago

The way I understand adding a P2SH address to watch was via importmulti with the relevant P2PK addresses involved. Not tested if this works but that would be the behaviour I would expect.

I'll try that. However, importaddress works for adding P2SH RVN balances to the 'Watch only' list, and there is no 'Watch only' list for P2PKH Assets either (added via importaddress) which leads me to believe that adding this feature for Asset Balances may have simply been overlooked.