search

RavenProject / Ravencoin

Ravencoin Core integration/staging tree
https://www.ravencoin.org
MIT License
1.08k stars 674 forks source link

Please add open-source hardware wallet support in the Qt #862

Open jeroz1 opened 3 years ago

jeroz1 commented 3 years ago

It significantly increases security as someone accessing your computer would also need access to the hardware device.

jeroz1 commented 3 years ago

I found this that may help: https://github.com/bitcoin-core/HWI/blob/master/docs/bitcoin-core-usage.md

MangoFarmAssets commented 3 years ago

+1

It would be great to add asset support on hardware, in addition to RVN transactions, focusing first on Trezor (because it is fully open source and the developers have done substantial work supporting and advancing open source wallet technology, including devising BIP39/44).

Ledger is a widely used and useful wallet, but I would suggest not to add a storage mechanism with a closed source chip and firmware to a core platform (at least without some sort of warning).

mknippen commented 3 years ago

+1 to hardware support. I think while Trezor may be more open source, there's still a much larger user base on Ledger, and it's pretty widely accepted as a very secure way to hold your assets

jeroz1 commented 3 years ago

Ravencoin Foundation Core Protocol Development Proposal 002 addresses this issue and awards $10,000 for this work.

https://gateway.ravencoinipfs.com/ipfs/QmNj9ozPddyh9hKY8H1k4cBeWzE4ptKcDY6fTzRF2Fo8Cu

hans-schmidt commented 3 years ago

I support and share the desire to have hardware wallet support for Ravencoin and for Ravencoin assets.

But in my opinion, attempting to add such support to the core raven-qt wallet at this time is a bad idea. Doing this in a way which satisfies the security and maintainability requirements of raven-qt would be a massive project. It is important that we respect the time and talents of developers who contribute to Ravencoin, so I believe it is important to speak up when a bounty calls for code which I believe is unlikely to result in a PR which will ever get merged.

This topic has been under continuous debate and development in the bitcoin core community for at least the past three years. We certainly don't want vendor specific code in raven-qt. Andrew Chow's python-code HWI add-on to bitcoin-qt is the current state-of-the-art. But it is still quite difficult to use and requires a number of bitcoin-qt features not currently implemented in raven-qt. Even Andrew has stated that eventual proper support in bitcoin-qt requires a major refactoring of the Wallet class and support for PSBTs and Descriptors.

There are other strategies which we could pursue to achieve our goal.

1) We could offer financial and/or developer support throught bounties to one or more wallet vendors to support Ravencoin and Ravencoin assets natively in their applications.

2) We should set up a bounty for a fully asset-aware Ravencoin version of Electrum (both Client and Server) with Hardware Wallet support. We should also support development of a Ravencoin version of the Electrum Personal Server so that the Raven-Electrum client could be optionally served by a local raven-qt instance via the RPC port rather than by a remote Raven-Electrum server.

Having #1 would give non-technical Ravencoin users the convenience of using Hardware Wallets the same way they are used by most bitcoin users. The primary disadvantage is the privacy risk associated with always connecting to the wallet vendor's servers.

Having #2 would allow an improvement in privacy as well as easy feature upgradeability due to the python codebase. The most privacy-sensitive users could use the Raven-Electrum client with the Raven-Electrum Personal Server and a locally running raven-qt to avoid any privacy compromises at all.

mknippen commented 3 years ago

Totally makes sense. I wonder if there's a third option for at least Ledger: Getting someone to build Ravencoin support directly into Ledger Live.

Perhaps this is done with help from someone at the Ledger team, or a 3rd party developer. There's a few good reasons for this:

  1. Ledger users are in many ways attached and incentivized to use the Ledger Live system.
  2. It's awfully convenient to see all of your assets in one place, in a way that's secured offline.
  3. Many Ledger users only buy if it's supported in this platform.

Having Ravencoin on Ledger Live not only increases exposure, but also gives a huge convenience to the biggest hardware wallet on the market. Historically, smaller coins have seen a price increase has happened.

The bigger question is the development required. I've personally never added a coin to Ledger Live, but it is open source (https://github.com/LedgerHQ/ledger-live-desktop), and it could be the Ledger team that handles a big chunk of the work.

With Ravencoin growing so rapidly, maybe this would be worth reaching out to the Ledger team to see if they would consider taking this on?

jeroz1 commented 3 years ago

Ledger wanted us to write a third party app. So that's what we did. They would reevaluate adding it on ledger live whenever they see fit...

MangoFarmAssets commented 3 years ago

Bump. Bitcoin Core 22.0 has GUI support for hardware wallets. It was a good idea when we discussed this in January and remains a good one now. Perhaps we can leverage the work BTC devs have done to get it going.