Add the ability to send to Assets! rather than just addresses

corviato1 commented 3 years ago

Title explains it all, going to make a gitcoin bounty for 0.3 ETH and encourage others to donate to this cause, it will add so much value to asset names. If this works, I will do another bounty for incoming RVN and memos to list all of the Asset! name of the sender for much more $$ and by then I hope this second bounty gains more traction with the community

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.3 ETH (173.69 USD @ $578.98/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Chat
- $999,143.41 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 265 years, 9 months from now. Please review their action plans below:

1) yorksvit has applied to start work _(Funders only: approve worker | reject worker)_.

how can i withdraw t-bone oral funds to my wallet 2) surajsingla333 has been approved to start work.

Hello, I have been working in the blockchain field for the past 2 years and would like to contribute to the project. It will be a great feature if it can be implemented. Currently, I can think of adding a feature in the asset's smart contract to make the functionality and will start with the same approach. We can discuss more about this, to get to a common understanding and make it happen. 3) thisispalash has been approved to start work.

Hi, I am highly interested in this project. Seems quite doable. I have one question, are you looking for a good UI too? Because if so, I might need to set up Android Studio and everything.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

thisispalash commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[ ] reminder (3 days)

[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes, I am working on this issue. Right now I'm still trying to figure out the environment and am getting the following error when I build the project,

Execution failed for task ':app:processRvnTestnetDebugGoogleServices'.
> No matching client found for package name 'com.ravenwallet'

I am presuming that this is because of the applicationId of productFlavors.rvnTestnet is "com.ravenwallet". I am not sure how to fix this, I've already reinstalled the project, Android Studio and firebase. Also, the firebase SDK installation says to use google-services:4.3.5 and not google-services:4.2.0 as in the repo. Should I update?

Finally, what is the timeline you guys are looking at? Since classes have started at uni, I was thinking ~2-3 weeks. Hence, escalation as well.

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

TronBlack commented 3 years ago

I think testnet is wired up to some Cloud-based diagnostic services. The ravenwallet.com domain belongs to a previous developer on the project (Roshii). He’s now working on an API-based wallet with RVN and Ravencoin asset support ( Stibits)

corviato1 commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)

[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

thisispalash commented 3 years ago

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[ ] reminder (3 days)

[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

yes.

I think testnet is wired up to some Cloud-based diagnostic services. The ravenwallet.com domain belongs to a previous developer on the project (Roshii). He’s now working on an API-based wallet with RVN and Ravencoin asset support ( Stibits)

ok, so what should I replace the applicationID with? All the different build variants are still failing. here's the code for easy reference -

productFlavors {
        rvn {
            applicationId = "com.ravenwallet"
            dimension "mode"
            resValue "string", "app_name", "RVN Wallet"
            buildConfigField "boolean", "TESTNET", "false"

            externalNativeBuild {
                cmake {
                    // When you specify a version of CMake, as shown below,
                    // the Android plugin searches for its binary within your
                    // PATH environmental variable.
                    cFlags ""
                    targets "core"
                }
            }
        }

        rvnTestnet {
            applicationId = "com.ravenwallet"
            dimension "mode"
            resValue "string", "app_name", "RVN-testnet"
            buildConfigField "boolean", "TESTNET", "true"

            externalNativeBuild {
                cmake {
                    // When you specify a version of CMake, as shown below,
                    // the Android plugin searches for its binary within your
                    // PATH environmental variable.
                    cFlags "-DTESTNET=1"
                    targets "core"
                }
            }

        }

    }

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

corviato1 commented 3 years ago

Yes

On Fri, Feb 19, 2021, 9:15 AM Gitcoin.co Bot notifications@github.com wrote:

@surajsingla333 https://github.com/surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)

escalation to mods (6 days)

Funders only: Snooze warnings for 1 day https://gitcoin.co/issue/RavenProject/ravenwallet-android/82/100024539?snooze=1 | 3 days https://gitcoin.co/issue/RavenProject/ravenwallet-android/82/100024539?snooze=3 | 5 days https://gitcoin.co/issue/RavenProject/ravenwallet-android/82/100024539?snooze=5 | 10 days https://gitcoin.co/issue/RavenProject/ravenwallet-android/82/100024539?snooze=10 | 100 days https://gitcoin.co/issue/RavenProject/ravenwallet-android/82/100024539?snooze=100

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RavenProject/ravenwallet-android/issues/82#issuecomment-782213220, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKVUULGR2LUBBXVP4VELMBLS72MCXANCNFSM4VHXRPZQ .

thisispalash commented 3 years ago

Ok, so I got the app to build. Turns out I had to change the applicationID in the app gradle to my applicationID from firebase rip. Sorry first time using Android Studio and Firebase.

I have another question, how do I enter the testnet on the app and is there a faucet so I can try some things with some raven? Right now, I am unable to do anything as my wallet is empty.

Also, I am a little confused with the issue. As I understand it currently, you want to be able to send to an asset name instead of an address. So, If I create an asset called iykyk, a smart contract address is generated and others can send to this address. But you want them to be able to send them directly to iykyk?

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@thisispalash due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@thisispalash due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

[x] reminder (3 days)
[x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

thisispalash commented 3 years ago

Hi, I'm sorry but I have to drop this bounty due to communication gaps.

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

TronBlack commented 3 years ago

Ok, so I got the app to build. Turns out I had to change the applicationID in the app gradle to my applicationID from firebase rip. Sorry first time using Android Studio and Firebase.

I have another question, how do I enter the testnet on the app and is there a faucet so I can try some things with some raven? Right now, I am unable to do anything as my wallet is empty.

Also, I am a little confused with the issue. As I understand it currently, you want to be able to send to an asset name instead of an address. So, If I create an asset called iykyk, a smart contract address is generated and others can send to this address. But you want them to be able to send them directly to iykyk?

There are no smart contracts in Ravencoin.
You should check with the author of this issue, but it might mean that they would like a way to send to the address that holds the admin token for an asset. When an asset is created, there is a single admin token like A_UNIQUE_ASSET! that ends in an exclamation mark. It can only be owned by a single address. They might want the ability to send to that address (by the name of the asset). Please check with the creator/funder of this issue to ensure these assumptions are correct.

gitcoinbot commented 3 years ago

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

RavenProject / ravenwallet-android

Add the ability to send to Assets! rather than just addresses #82