RavenProject / ravenwallet-ios

MIT License
25 stars 21 forks source link

Please add BIP39 Passphrase support #160

Open jeroz1 opened 3 years ago

jeroz1 commented 3 years ago

Users are unable to recover raven core seed words in the mobile wallets when they created a wallet with a passphrase.

TronBlack commented 3 years ago

I need to understand this better.

If the wallets were created with a 256-bit random number as a master key -- original version -- and then the wallet.dat is encrypted with a password, then there aren't 12-words to give to the user. They will need to back up the wallet.dat and keep/store the password.

Or the newer option, which is a 128-bit seed that creates the 256-bit master key from which the individual private keys (and associated addresses) are derived.

The new model lets them write down 12-words instead of backing up a wallet.dat. Unless they import private keys, in which case they get a warning that they need to back up the wallet.dat.

If they created with the original (not the newer BIP32, BIP39, BIP44 option), then there isn't a 12-word backup for them to get because it wasn't created that way.

jeroz1 commented 3 years ago

I’m not referring to the password for wallet.dat encryption but the optional passphrase when generating a seed at the first startup.

New users are under the impression that it encrypts their wallet but it doesn’t. And moreover, their seed words don’t work anymore in wallets that don’t support the extra optional passphrase. Such as the RVN mobile wallets.

I believe that seed words (plus optional passphrases) need to at least be seamlessly interchangeable across Ravencoin branded wallets on different devices.

jeroz1 commented 3 years ago

85EC3B9B-04C8-4A87-B778-C53D44EFC756 15FA8946-E01D-4962-9A1F-3D1F06E001C2