RavenProject / ravenwallet-ios

MIT License
25 stars 21 forks source link

New wallet still does BIP32 m/0'/0 derivation if the flag is set. #85

Closed TronBlack closed 5 years ago

TronBlack commented 5 years ago

Dan's first address was derived from m/0'/0

TronBlack commented 5 years ago

How could this have happened if the old derivation has been removed? Not a critical priority because it only affects internal testers.

Menwitz commented 5 years ago

He simply didn't wipe his wallet, there no flag in new code!

TronBlack commented 5 years ago

Public addresses are stored in the wallet. This was the case for Dan. The solution is to wipe the wallet. Any future derivations are BIP44. This will not be a problem after we solve for the internal testers only.