Ravenholdt-TC / Rogue

Anything you want to add into the dashboard should be done here.
4 stars 0 forks source link

[APL] Assassination cycle_targets TTD Conditions w/ Bracers #78

Closed EvanMichaels closed 6 years ago

EvanMichaels commented 6 years ago

I noticed while testing with AER that the cycle_targets refreshing of DoTs seemed oddly conservative when using the Bracers considering the additional execute damage.

I tested this as a quick proof of concept in SimC on Beastlord sims when using Bracers and it appeared to be a gain:

actions.maintain+=/rupture,cycle_targets=1,if=combo_points>=4&refreshable&(pmultiplier<=1|remains<=tick_time)&(!exsanguinated|remains<=tick_time*2)&target.time_to_die-remains>6

vs.

actions.maintain+=/rupture,cycle_targets=1,if=combo_points>=4&refreshable&(pmultiplier<=1|remains<=tick_time)&(!exsanguinated|remains<=tick_time*2)&target.time_to_die-remains>4

T21_Rogue_Assassination : 3529941 dps, 2116847 dps to main target T21_Rogue_Assassination_alter : 3617110 dps, 2131623 dps to main target

However, I did not have time to do comprehensive tests on the specific remains, adding to other lines, adding to Garrote, etc. This may need more investigation.

EvanMichaels commented 6 years ago

https://github.com/simulationcraft/simc/commit/364aa06dfeac2124a5c0d0c22bef7293f8f23a44