search

Ravenholdt-TC / Rogue

Anything you want to add into the dashboard should be done here.
4 stars 0 forks source link

[APL] [Assassination] Investigate Kingsbane Conditionals #87

Closed EvanMichaels closed 6 years ago

EvanMichaels commented 6 years ago

Current Kingsbane conditions may not be appropriately leveraging Nightstalker with the current state of gear scaling. Additionally, some of the conditionals seem defunct with current scaling, even when using the T19 or CoF setups.

Currently testing the following alteration from: actions.kb=kingsbane,if=artifact.sinister_circulation.enabled&!(equipped.duskwalkers_footpads&equipped.convergence_of_fates&artifact.master_assassin.rank>=6)&(time>25|!equipped.mantle_of_the_master_assassin|(debuff.vendetta.up&debuff.surge_of_toxins.up))&(talent.subterfuge.enabled|!stealthed.rogue|(talent.nightstalker.enabled&(!equipped.mantle_of_the_master_assassin|!set_bonus.tier19_4pc)))

To: actions.kb=kingsbane,if=talent.nightstalker.enabled|(!stealthed.rogue&time>2)

This appears to be a gain in most cases, but need to run more combinations to confirm.

EvanMichaels commented 6 years ago

https://www.raidbots.com/simbot/report/hQ5zyYS8GZh8ptVmBecWPV

EvanMichaels commented 6 years ago

Fixed in https://github.com/simulationcraft/simc/commit/8043db3a0f3e7d9e6ab3f661f2580bbdcdc74294