Ravenholdt-TC / Rogue

Anything you want to add into the dashboard should be done here.
4 stars 0 forks source link

[BUG] Mutilate hits that are partially blocked cannot crit #90

Open Kiwifruity opened 6 years ago

Kiwifruity commented 6 years ago

Game Version:

7.3.5.25928

Description:

Mutilate hits that are partially blocked by the target can not crit

Reproduce rate:

100%

Details:

If a boss partially blocks a Mutilate (main hand or off-hand hit) that mutilate can not crit, even when under the effects of 100% crit modifiers like Mantle of the Master Assassin. This causes Seal Fate to not proc when it should. Other abilities, like Monk's Rising Sun Kick, can crit when they are partially blocked, so its inconsistent that Mutilate can not crit.

Log: https://www.warcraftlogs.com/reports/kwDLCY4HKyzqGFa8/#fight=last&type=damage-done&source=1&start=1134234&end=1144285&view=events

Howto:

Stand in front of a dummy/boss, hit the dummy/boss with mutilate while under the effects of Mantle of the Master Assassin to ensure 100% crit rate, observe mutilate's not critting when blocked, and thus not proccing Seal Fate.

EvanMichaels commented 6 years ago

To expound on this based on more detailed findings/testing today. This applies to all yellow attacks that used weapon DPS. Yellow attacks that use AP damage or white attacks are not affected.

Full encounter log of all hits that were blocked and did crit: https://www.warcraftlogs.com/reports/HW4hXjykM8vq2RBp#type=damage-done&pins=2%24Separate%24%23244F4B%24damage%24-1%240.0.0.Any%240.0.0.Any%24true%240.0.0.Any%24true%240%243567&view=events&boss=-2&difficulty=0

Full encounter log of all hits that were blocked but did not crit: https://www.warcraftlogs.com/reports/HW4hXjykM8vq2RBp#type=damage-done&pins=2%24Separate%24%23244F4B%24damage%24-1%240.0.0.Any%240.0.0.Any%24true%240.0.0.Any%24true%240%243575&view=events&boss=-2&difficulty=0

As you can see, there is not a single WDPS-based ability in the first list, despite many WDPS abilities in the second list. I could not find any cases of a WDPS-based yellow attack that was both at the same time.