Ravenholdt-TC / Rogue

Anything you want to add into the dashboard should be done here.
4 stars 0 forks source link

[APL] [Assassination] Improvement on 2-targets fights for Exsanguinate build #91

Closed BatushkaDB closed 6 years ago

BatushkaDB commented 6 years ago

Wondering if i should FoK on 2 targets with Exsanguinate build or not, i've made some tests.

I replaced the following current builder APL section

actions.build=hemorrhage,if=refreshable actions.build+=/hemorrhage,cycle_targets=1,if=refreshable&dot.rupture.ticking&spell_targets.fan_of_knives<2+equipped.insignia_of_ravenholdt actions.build+=/fan_of_knives,if=spell_targets>=2+equipped.insignia_of_ravenholdt|buff.the_dreadlords_deceit.stack>=29 actions.build+=/fan_of_knives,if=variable.use_fok_rotation actions.build+=/mutilate,cycle_targets=1,if=dot.deadly_poison_dot.refreshable actions.build+=/mutilate

for this one :

actions.build=hemorrhage,if=refreshable actions.build+=/hemorrhage,cycle_targets=1,if=refreshable&dot.rupture.ticking&spell_targets.fan_of_knives<2+equipped.insignia_of_ravenholdt actions.build+=/fan_of_knives,if=spell_targets>=3|buff.the_dreadlords_deceit.stack>=29 actions.build+=/mutilate,if=debuff.vendetta.up|combo_points<=2 actions.build+=/fan_of_knives,if=spell_targets>=2+equipped.insignia_of_ravenholdt actions.build+=/fan_of_knives,if=variable.use_fok_rotation actions.build+=/mutilate,cycle_targets=1,if=dot.deadly_poison_dot.refreshable actions.build+=/mutilate

It appears to be a gain : exsgnew

I haven't tried anything for the poison build, nor for 3 targets fights/ There's might also be some improvement possible on this

EvanMichaels commented 6 years ago

Thanks for the report, I will try this out on a few other builds as well. Seems like a pretty clear increase for 2T scenarios!

EvanMichaels commented 6 years ago

I have integrated this with some modifications into https://github.com/simulationcraft/simc/commit/ebcfcb26074f617519e2a00bc501daeb2355adda

This was a loss for Poison builds so needed to make sure this was Exsang only.