Ravenholdt-TC / Rogue

Anything you want to add into the dashboard should be done here.
4 stars 0 forks source link

[APL] [Assassination] Investigate Finisher Conditionals #92

Closed EvanMichaels closed 6 years ago

EvanMichaels commented 6 years ago

Current conditionals for the Finish action list are likely no longer needed: actions+=/call_action_list,name=finish,if=(!talent.exsanguinate.enabled|cooldown.exsanguinate.remains>2)&(!dot.rupture.refreshable|(dot.rupture.exsanguinated&dot.rupture.remains>=3.5)|target.time_to_die-dot.rupture.remains<=6)&active_dot.rupture>=spell_targets.rupture

Given the Envenom costs more Energy than Rupture and given that the Maintain list is called prior to Finish, the majority of these are irrelevant or potentially disruptive to the APL.

Removing all these conditionals appears to be a gain for both the default APL and default Exsanguinate APL.

Default ST: https://www.raidbots.com/simbot/report/jZLa4xpopbQMRJVVZLYdb9 Default 2T: https://www.raidbots.com/simbot/report/cm6KARrJC2jQKPNHaiCGot Default Exsang ST: https://www.raidbots.com/simbot/report/wAVR9yUqJDKe8kD8bKKx1m Default Exsang 2T: https://www.raidbots.com/simbot/report/mGW6gF88dCpLYRW2FsFvPw

EvanMichaels commented 6 years ago

It appears the only relevant DPS-increasing conditional here is: (!talent.exsanguinate.enabled|cooldown.exsanguinate.remains>2)

As seen with single-part variants here: https://www.raidbots.com/simbot/report/iEj3mGKTEbbYENbuzfaBxK

Stripping the conditional down to only the conditional above (variant B) results in a 17k DPS increase for the default Exsang profiles for ST and is neutral in 2T.

EvanMichaels commented 6 years ago

Fixed in https://github.com/simulationcraft/simc/commit/71285e58a5e68b40392b00faa0dce16104eb14a3