search

Ravenports / ravenadm

Administration tool for Ravenports
http://www.ravenports.com
ISC License
17 stars 3 forks source link

Improve catalog website #1

Open mneumann opened 6 years ago

mneumann commented 6 years ago

This is already very good, but I think a few things can be improved:

Also I would not put the catalog information directly into the index.js (expanded from catalog.template), instead I would move the catalog data to a separate catalog.json file and load it from index.js. This has a lot of advantages IMHO. I might help with that, so this issue is more of a reminder :)

jrmarino commented 6 years ago

The first bullet is impractical because there's not a 1:1 ratio of categories to ports. A port can have an unlimited number of "keywords". Some have like 4. There's no real estate to display an unknown number of keywords.

The sort is already "last updated first". When a new port is added, it will be at the top then. To sort by first added would require another very wide date column (or at the very least another number column). The date column takes up too much room. The real question is , "Is such a feature truly useful?" as in, who needs it and why?

as for the third, I would be interested in knowing what the advantages are. The web browser should cache index.js and only refetch when it changes, so it's unclear to me why the current method is bad.

mneumann commented 6 years ago

As for the keywords: think about a tag cloud. you can select as many keywords as you want to drill down your search.

as for the third: no big deal. just, in general, I would prefer separating code and data. also, the data alone could be useful for other purposes (fetching and interpreting JSON with a scripting language is just a few lines of code). I don't have a concrete use case yet, but for instance, I can write a Ruby one-liner that displays the number of ports, whatever.