Ravenports / ravenadm

Administration tool for Ravenports
http://www.ravenports.com
ISC License
17 stars 3 forks source link

Relax the strict doc cheching for example sub-packages #20

Closed kraileth closed 4 years ago

kraileth commented 4 years ago

Testing the ocl-icd port currently fails after doc-related errors switched from warning to error. This program provides an example file where the path contains "doc" (i.e. share/doc/ocl-icd/examples/ocl_icd_bindings.c).

Might make sense to treat "example" sub-packages specially as well and allow docy stuff in it.

jrmarino commented 4 years ago

nope. Either that example file has to be moved to the examples directory or that requires a docs subpackage or it should just be removed from packaging if it's not worth anything.

I don't see a reason to relax the strict checking here. That checking was put in place to catch a bad actor like ocl-icd. let's fix the port.

kraileth commented 4 years ago

Guess that I have to get rid of the "upstream is right" attitude... We're already bending a lot of packages to meet our standards after all. Ok, I'll take care of the offender.

jrmarino commented 4 years ago

a more common problem is when the port installs in a directory that is not "share/doc/$NAMEBASE" . In that case we have to relocate manually in post-install.

kraileth commented 4 years ago

Just relocated the file of that port. Closing.