search

RaviSoji / plda

Probabilistic Linear Discriminant Analysis & classification, written in Python.
https://ravisoji.com
Apache License 2.0
128 stars 31 forks source link

Added method on PLDA model to perform similarity #50

Closed seandickert closed 5 years ago

seandickert commented 5 years ago

Similarity score between two sets of utterances, possibly from speakers not in the training set

seandickert commented 5 years ago

Will do, will update soon

On Sat, May 11, 2019, 6:26 PM Ravi notifications@github.com wrote:

@RaviSoji requested changes on this pull request.

Looks great, but I haven't had a chance to run it. I assume it's working for you?

Also, it may be worth renaming some variables so things are clear to future users. For example, renaming the similarity() method to calc_same_diff_likelihood_ratio() may be more informative and changing the speaker language in the test to "category" or something like that may be helpful.

Let me know if you'd want to make those changes. They are minor, but I can also make them if you'd like.

Many thanks for coding this up!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RaviSoji/plda/pull/50#pullrequestreview-236394441, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRMJAGE2V6SJ766XHYJOXLPU5BX7ANCNFSM4HL2IUAQ .

seandickert commented 5 years ago

Made the changes. Sorry, didn't respond to the first question before, but yes, it's working for me.

RaviSoji commented 5 years ago

Hey, sorry I've been swamped with school and work. I'll have a chance this weekend to merge.

Thanks again!!

RaviSoji commented 5 years ago

Hey, apologies for the delay. I went ahead and just merged it since it looks good and it's working for you.

Thanks again for doing this!