search

RavinderReddyF5 / terraform-provider-bigip-version0.12

Terraform resources that can configure F5 BIGIP products
Mozilla Public License 2.0
0 stars 0 forks source link

[CLOSED] allow uploading policies to a specific partition #166

Open RavinderReddyF5 opened 4 years ago

RavinderReddyF5 commented 4 years ago

Issue by jlosito Wednesday Jul 24, 2019 at 20:33 GMT Originally opened as https://github.com/terraform-providers/terraform-provider-bigip/issues/135

Currently, the ltm_policy resource does not have the ability to upload policies to a partition which is not Common.

RavinderReddyF5 commented 4 years ago

Comment by dannyk81 Thursday Jul 25, 2019 at 00:29 GMT

indeed it is a bug I mentioned several times, since the Common partition is hard coded in the code.

@scshitole

RavinderReddyF5 commented 4 years ago

Comment by jlosito Thursday Jul 25, 2019 at 00:49 GMT

We have a working change that allows for uploading to a specific partition. We are planning to submit a PR once we've tested a little more.

I think the issue is a partition name is never passed to the rest client, so the rest client assumes Common since it's the default.

RavinderReddyF5 commented 4 years ago

Comment by dannyk81 Thursday Jul 25, 2019 at 01:00 GMT

the issue is in the go-bigip library, specifically here https://github.com/terraform-providers/terraform-provider-bigip/blob/e6f13aa07b8783bf38af8aa34d0a59a4bb119db3/vendor/github.com/f5devcentral/go-bigip/ltm.go#L2582

as you can see ~Common~ is always added to the policy name.

RavinderReddyF5 commented 4 years ago

Comment by jlosito Wednesday Aug 14, 2019 at 14:00 GMT

@scshitole Can we reopen this since the changes were reverted?