search

RavinderReddyF5 / terraform-provider-bigip-version0.12

Terraform resources that can configure F5 BIGIP products
Mozilla Public License 2.0
0 stars 0 forks source link

[CLOSED] fix for #148 #180

Open RavinderReddyF5 opened 4 years ago

RavinderReddyF5 commented 4 years ago

Issue by scshitole Friday Aug 16, 2019 at 16:44 GMT Originally opened as https://github.com/terraform-providers/terraform-provider-bigip/pull/149


=== RUN   TestAccBigipLtmNode_create
--- PASS: TestAccBigipLtmNode_create (6.09s)
=== RUN   TestAccBigipLtmNode_import
--- PASS: TestAccBigipLtmNode_import (6.05s)
=== RUN   TestAccBigipLtmNodeInvalid
--- PASS: TestAccBigipLtmNodeInvalid (0.01s)
=== RUN   TestAccBigipLtmNodeCreate
--- PASS: TestAccBigipLtmNodeCreate (0.06s)

scshitole included the following code: https://github.com/terraform-providers/terraform-provider-bigip/pull/149/commits

RavinderReddyF5 commented 4 years ago

Comment by scshitole Friday Aug 16, 2019 at 17:36 GMT

@dannyk81 @jlosito can you please review

RavinderReddyF5 commented 4 years ago

Comment by dannyk81 Saturday Aug 17, 2019 at 02:52 GMT

@scshitole thanks for this fix, however you merged this before we had the chance to go over it.

so here are my comments:

  1. This attribute shouldn't have a Default defined, it is not needed and just creates confusion. Description defaults to an empty string anyway.

  2. you only fixed Node resource, same fixes required in the VS and Pool resources.

RavinderReddyF5 commented 4 years ago

Comment by RavinderReddyF5 Monday Aug 19, 2019 at 09:04 GMT

Hi @scshitole @dannyk81 @jlosito

please review Changes for Description issue fix for Pool and Virtual Server. https://github.com/terraform-providers/terraform-provider-bigip/pull/151

RavinderReddyF5 commented 4 years ago

Comment by dannyk81 Monday Aug 19, 2019 at 15:09 GMT

Left some comments in #151, thanks!