RavinderReddyF5 / terraform-provider-bigip-version0.12

Terraform resources that can configure F5 BIGIP products
Mozilla Public License 2.0
0 stars 0 forks source link

[CLOSED] Content argument of `bigip_ssl_key` should be marked sensitive #239

Open RavinderReddyF5 opened 4 years ago

RavinderReddyF5 commented 4 years ago

Issue by lpugoy Friday Nov 29, 2019 at 03:33 GMT Originally opened as https://github.com/terraform-providers/terraform-provider-bigip/issues/208


The content argument of bigip_ssl_key should be marked sensitive so that it won't be shown as plain text when running terraform plan.

Expected output

$ terraform plan
Terraform will perform the following actions:

  # bigip_ssl_key.keyname will be created
  + resource "bigip_ssl_key" "keyname" {
      + content   = (sensitive)
      ...

Actual output

$ terraform plan
Terraform will perform the following actions:

  # bigip_ssl_key.keyname will be created
  + resource "bigip_ssl_key" "keyname" {
      + content   = <<~EOT
            -----BEGIN PRIVATE KEY-----
            ...
            -----END PRIVATE KEY-----
        EOT
      ...

The password argument in aws_db_instance provides an example.

RavinderReddyF5 commented 4 years ago

Comment by RavinderReddyF5 Friday Nov 29, 2019 at 05:35 GMT


@lpugoy thanks for reporting issues. sure will provide fix for the same as you suggested.

RavinderReddyF5 commented 4 years ago

Comment by RavinderReddyF5 Friday Nov 29, 2019 at 07:13 GMT


@lpugoy issue fixed through https://github.com/terraform-providers/terraform-provider-bigip/commit/39553e00174766307ee4fa31932ad1cccddffdbd

RavinderReddyF5 commented 4 years ago

Comment by lpugoy Sunday Dec 01, 2019 at 23:56 GMT


Thanks @RavinderReddyF5 for the speedy resolution. You can close this at your convenience.