search

RavinderReddyF5 / terraform-provider-bigip-version0.12

Terraform resources that can configure F5 BIGIP products
Mozilla Public License 2.0
0 stars 0 forks source link

[CLOSED] Dev branch #60

Open RavinderReddyF5 opened 4 years ago

RavinderReddyF5 commented 4 years ago

Issue by scshitole Monday Dec 17, 2018 at 18:00 GMT Originally opened as https://github.com/terraform-providers/terraform-provider-bigip/pull/29

did dep ensure -update to update vendor dir

scshitole included the following code: https://github.com/terraform-providers/terraform-provider-bigip/pull/29/commits

RavinderReddyF5 commented 4 years ago

Comment by dannyk81 Monday Dec 17, 2018 at 18:31 GMT

@scshitole looks like you merged a PR that failed CI... this seems a bit problematic.

RavinderReddyF5 commented 4 years ago

Comment by scshitole Monday Dec 17, 2018 at 19:49 GMT

@dannyk81 no code change in the resources only vendor update looks like lint errors should I revert back ? I did test the build locally and it was fine

RavinderReddyF5 commented 4 years ago

Comment by dannyk81 Monday Dec 17, 2018 at 20:19 GMT

I see, a whole bunch of lint errors 😬 I suppose there's no point in reverting, as this is a pre-existing situation.

But, this is something that should be addressed to improve code quality.