[CLOSED] updated travis file

[RavinderReddyF5]

Issue by scshitole Thursday Jan 03, 2019 at 22:16 GMT Originally opened as https://github.com/terraform-providers/terraform-provider-bigip/pull/32

---

---

scshitole included the following code: https://github.com/terraform-providers/terraform-provider-bigip/pull/32/commits

[RavinderReddyF5]

Comment by scshitole Thursday Jan 03, 2019 at 22:22 GMT

---

@dannyk81 I did ran make fmt and go fmt make fmt ==> Fixing source code with gofmt... gofmt -s -w ./bigip SJC-ML-00028512:terraform-provider-bigip shitole$ git status On branch dev-branch Your branch is up to date with 'origin/dev-branch'.

nothing to commit, working tree clean

also make test ==> Checking that code complies with gofmt requirements... go test ./... -timeout=30s -parallel=4 ? github.com/terraform-providers/terraform-provider-bigip [no test files] ok github.com/terraform-providers/terraform-provider-bigip/bigip 0.145s

[RavinderReddyF5]

Comment by dannyk81 Thursday Jan 03, 2019 at 22:30 GMT

---

dannyk ~/work/gocode/src/github.com/terraform-providers/terraform-provider-bigip/bigip $ git checkout dev-branch
Switched to branch 'dev-branch'
Your branch is up to date with 'origin/dev-branch'.
dannyk ~/work/gocode/src/github.com/terraform-providers/terraform-provider-bigip/bigip $ go fmt *
resource_bigip_ltm_virtual_server.go
resource_bigip_sys_snmp_traps.go
dannyk ~/work/gocode/src/github.com/terraform-providers/terraform-provider-bigip/bigip $ git status
On branch dev-branch
Your branch is up to date with 'origin/dev-branch'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   resource_bigip_ltm_virtual_server.go
        modified:   resource_bigip_sys_snmp_traps.go

no changes added to commit (use "git add" and/or "git commit -a")

dannyk ~/work/gocode/src/github.com/terraform-providers/terraform-provider-bigip $ gofmt -s -w ./bigip/
dannyk ~/work/gocode/src/github.com/terraform-providers/terraform-provider-bigip $ git status
On branch dev-branch
Your branch is up to date with 'origin/dev-branch'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   bigip/resource_bigip_ltm_virtual_server.go
        modified:   bigip/resource_bigip_sys_snmp_traps.go

no changes added to commit (use "git add" and/or "git commit -a")

Something seems screwed up on your local branch...

[RavinderReddyF5]

Comment by scshitole Thursday Jan 03, 2019 at 22:34 GMT

---

@dannyk81 git status On branch dev-branch Your branch is up to date with 'origin/dev-branch'.

nothing to commit, working tree clean SJC-ML-00028512:terraform-provider-bigip shitole$ SJC-ML-00028512:terraform-provider-bigip shitole$ SJC-ML-00028512:terraform-provider-bigip shitole$ pwd /Users/shitole/top/src/github.com/terraform-providers/terraform-provider-bigip SJC-ML-00028512:terraform-provider-bigip shitole$ cd bigip/ SJC-ML-00028512:bigip shitole$ go fmt * SJC-ML-00028512:bigip shitole$ git status On branch dev-branch Your branch is up to date with 'origin/dev-branch'.

nothing to commit, working tree clean SJC-ML-00028512:bigip shitole$

somehow I am not able to see the modified files ?

[RavinderReddyF5]

Comment by dannyk81 Thursday Jan 03, 2019 at 22:39 GMT

---

well, we can keep exchanging outputs 😄

But, if you do a clean git clone for master and/or dev-branch and run go fmt * in bigip folder you should see that two files are missing formatting.

[RavinderReddyF5]

Comment by dannyk81 Thursday Jan 03, 2019 at 22:39 GMT

---

Travis sees the exact same thing, I think it's you local branch that is out of whack.

[RavinderReddyF5]

Comment by scshitole Thursday Jan 03, 2019 at 22:44 GMT

---

@dannyk81 still not able to see, I deleted my local branch and created again sh f5pro.sh go version go1.10.3 darwin/amd64 Creating directory workspace Creating subdirectories ... Downloading code from github repo https://github.com/terraform-providers/terraform-provider-bigip Building the provider ... fetching .TF file from Github ... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 191 100 191 0 0 1030 0 --:--:-- --:--:-- --:--:-- 1032 Now Change directory path to /Users/shitole/top/src/github.com/terraform-providers/terraform-provider-bigip Done ready to use !!!?m SJC-ML-00028512:~ shitole$ SJC-ML-00028512:~ shitole$ SJC-ML-00028512:~ shitole$ SJC-ML-00028512:~ shitole$ cd SJC-ML-00028512:~ shitole$ SJC-ML-00028512:~ shitole$ pwd /Users/shitole SJC-ML-00028512:~ shitole$ cd top/src/github.com/terraform-providers/terraform-provider-bigip/ SJC-ML-00028512:terraform-provider-bigip shitole$ git status On branch master Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean SJC-ML-00028512:terraform-provider-bigip shitole$ SJC-ML-00028512:terraform-provider-bigip shitole$ cd bigip/ SJC-ML-00028512:bigip shitole$ go fmt * SJC-ML-00028512:bigip shitole$ cd .. SJC-ML-00028512:terraform-provider-bigip shitole$ git status On branch master Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean SJC-ML-00028512:terraform-provider-bigip shitole$

cat f5pro.sh 
#!/bin/bash
cd
go version
echo "Creating directory workspace"
mkdir top
export GOPATH=$HOME/top
echo "Creating subdirectories ..."
mkdir -p $GOPATH/src/github.com/terraform-providers
cd $GOPATH
echo "Downloading code from github repo https://github.com/terraform-providers/terraform-provider-bigip"
go get github.com/terraform-providers/terraform-provider-bigip
cd $GOPATH/src/github.com/terraform-providers/terraform-provider-bigip/
echo "Building the provider ..."
echo "\033[1m fetching .TF file from Github ...\033[0m \c"
curl https://raw.githubusercontent.com/terraform-providers/terraform-provider-bigip/master/examples/bigip_ltm_node.tf -o master.tf
echo "Now Change  directory path to $GOPATH/src/github.com/terraform-providers/terraform-provider-bigip"
echo "\033[1mDone ready to use !!!\0330m \c"

[RavinderReddyF5]

Comment by scshitole Thursday Jan 03, 2019 at 22:58 GMT

---

@dannyk81 maybe I will make few changes to the files in comment section, save the file and see how it goes. What go version you are using ? mine is

go version
go version go1.10.3 darwin/amd64

[RavinderReddyF5]

Comment by scshitole Thursday Jan 03, 2019 at 23:41 GMT

---

@dannyk81 it was GO version issue

 sh f5pro.sh 
go version go1.11.4 darwin/amd64
Creating directory workspace
Creating subdirectories ...
Downloading code from github repo https://github.com/terraform-providers/terraform-provider-bigip
Building the provider ...
 fetching .TF file from Github ...   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   191  100   191    0     0   3336      0 --:--:-- --:--:-- --:--:--  3350
Now Change  directory path to /Users/shitole/top/src/github.com/terraform-providers/terraform-provider-bigip
Done ready to use !!!?m SJC-ML-00028512:~ shitole$ cd /Users/shitole/top/src/github.com/terraform-providers/terraform-provider-bigip
SJC-ML-00028512:terraform-provider-bigip shitole$ cd bigip/
SJC-ML-00028512:bigip shitole$ go fmt *
resource_bigip_ltm_virtual_server.go
resource_bigip_sys_snmp_traps.go
SJC-ML-00028512:bigip shitole$ go version
go version go1.11.4 darwin/amd64
SJC-ML-00028512:bigip shitole$