search

Ravinou / borgwarehouse

A fast and modern WebUI for a BorgBackup's central repository server.
https://borgwarehouse.com
GNU Affero General Public License v3.0
314 stars 22 forks source link

Make ARGs compliant with Docker specs #235

Closed Forceu closed 2 weeks ago

Forceu commented 2 weeks ago

The arguments UID and GID were declared in the first FROM part of the Docker image, which made them non-compliant with the Docker specs. This resulted in a failed build, if the build was done without docker-compose:

RUN groupadd -g ${GID} borgwarehouse && useradd -m -u ${UID} -g ${GID} borgwarehouse
groupadd: invalid group ID 'borgwarehouse'

https://docs.docker.com/reference/dockerfile/#understand-how-arg-and-from-interact

Ravinou commented 2 weeks ago

Very interesting. I didn't know this subtlety at all, but it's very important. Thanks for the link to the documentation.