Ravinou / borgwarehouse

A fast and modern WebUI for a BorgBackup's central repository server.
https://borgwarehouse.com
GNU Affero General Public License v3.0
314 stars 22 forks source link

Add possibility to only use FQDN without SSH_SERVER_PORT env #237

Open Riushda opened 2 weeks ago

Riushda commented 2 weeks ago

When SSH_SERVER_PORT env is not set, it default to 22 here and is still used in the web command hints. In my local setup, I use a reverse proxy with domain name which forward automatically to correct ip and port. Thus it would be very handy to have to possibility to only specify FQDN url without Server port.

I'm not sure exactly what could be the best solution, either do not use port if not set (instead of using port 22 by default) or introducing a third env variable that is supposed to already contain the hostname and port (and use this one if set). I think the latter would ensure backward compatibility with existing setup.

Ravinou commented 2 weeks ago

Your case is interesting and deserves to be treated. I'll think about the best way to do it and incorporate the changes. Stay tuned ;)