Ravo92 / Patch-2.22-Launcher

BFME Launcher for BFME, BFME 2, ROTWK. Also known as 2.22 Launcher for Battle for Middle Earth 1
MIT License
32 stars 3 forks source link

Major refactoring of core systems, and new patch selection UI components. **Work in progress!** #46

Closed MarcellVokk closed 1 week ago

MarcellVokk commented 1 week ago

Major refactoring of core systems, and new patch selection UI components. Work in progress!

Ravo92 commented 1 week ago

Please check my latest changes and feedback here: https://github.com/Ravo92/Patch-2.22-Launcher/pull/46/commits/ef43b2fae825ffdc7a4a8edc6a72961691fec353

Ravo92 commented 1 week ago

Forgot some parts... https://github.com/Ravo92/Patch-2.22-Launcher/pull/46/commits/6e137c3b6d0b12785be5c228a26d2c3764264c6e

MarcellVokk commented 1 week ago

I took a quick look, and all seems fine, using enums instead of integers to specify the game is a good idea.

But, I have a problem with the naming convention you are using, it's inconsistent. Here are my suggestions:

The reason behind this is to maintain naming consistency across the project, since all other static classes follow the "UpperCamelCase" naming convention (eg.: SystemDisplayManager, SystemInputManager, LauncherStateManager, LauncherUpdateManager, etc...)

MarcellVokk commented 1 week ago

Looks good!