RayNieport / mconBot

A bot to interact with your Minecraft server - from Discord!
Other
19 stars 4 forks source link

Option to Specify Port #4

Closed stw222 closed 2 years ago

stw222 commented 2 years ago

Your bot seems pretty good despite a couple missing features. i looked at the python library you were using for mcrcon and it doesnt seem you can specify a port, so idk if this is possible i would attempt to fix it myself, but the only class in college ive had on python was more of the data science route and not normal programming.

I have my main server setup on a physical server (D1) where i want to have the bot running on a different physical server (D2) that physical server (D1) has a minecraft server and a velocity proxy. while the 2nd server (D2) has significantly less processing power, so i try to host smaller pieces of software on it. I want to be able to specify the port that i use with the bot since i was planning on using the bot, not on the same physical server (not D1, but D2 in this case). this would also help if i wanted to setup multiple instances of the bot for different servers

RayNieport commented 2 years ago

Glad you enjoy it! I'll look into supporting different ports. I may have to extend the current library, use a different one, or write my own.

If there are any other features you'd like to see please just let me know! I'd love to add them for you.

RayNieport commented 2 years ago

Hi there, you should be able to specify the port in the .env file now. Would you mind pulling the most recent code and testing this out? I tested it on my server but it's always nice to have another set of eyes.

stw222 commented 2 years ago

i tried it yesterday, it seemed to work, but also didnt. i was trying to use this with a velocity plugin, but that plugin seems to have an error that i may or may not have fixed. gotta test that

but then i tried it with the paper server i have and it didnt seem to work at all. like the server wasnt receiving anything.

i plan to try again sometime soon. i'll try it on the remote server and on the hardware where mc is hosted just in case. i would just prefer to run the bot on the remote server if possible.

stw222 commented 2 years ago

so i got the bot working when the bot and the server are on the same hardware. now i just need to figure out what im doing wrong when the bot and server are hosted on different hardware

stw222 commented 2 years ago

I have no idea what i was doing wrong before, but it does seem to work now to a remote server. now i need to test if it works with a velocity rcon plugin. (if it doesnt, your bot is probably not the problem)

stw222 commented 2 years ago

well, i guess this plugin has something implemented wrong. it seems to not give a response to a command and only shows that an rcon connection was made. that is probably why mconBot seems to think that the connection failed. This is of no fault of yourself (i think) but if you want to look into it, this is the plugin ive been trying to use https://github.com/UnioDex/VelocityRcon

RayNieport commented 2 years ago

Glad you got it working! I'm testing the bot on separate hardware, but still on the same local network as the Minecraft server. I would recommend doing it this way, since RCON is not encrypted. I might look into TLS/encryption for RCON in the future if I have time, but I'm not planning on it at the moment.

I will also update the Docker image sometime in the next week or two to add the >admin command and the option to specify a new port.

Sorry that the plugin you're trying to use isn't working. It must implement RCON slightly differently than vanilla Minecraft (although to be clear, this bot should work on Spigot and other non-vanilla servers).

Let me know if you have any other features you'd like to see added.