RayTrace082 / untamedwilds

GNU General Public License v3.0
14 stars 11 forks source link

1.18.2-1.2.3 Crash: 'bear sound is null' #163

Open ThatGuyJess opened 2 years ago

ThatGuyJess commented 2 years ago

Hello!

First I want to say I love this mod and appreciate the work you put into it! I am planning on donating something soon as a thank you gift.

Here's the scoop:

The mod crashes due to "Entity Type: untamedwilds:bear" ticking. It states below that despite the fix you made (which seemed to work for the mob(s?) that previously had this issue for my server, my friends, and I) there may still be some mobs that have the sound null issue:

"The game crashed whilst ticking entity Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.sounds.SoundEvent.m11660()" because "sound" is null Exit Code: -1"

Crash Log

What I did when it crashed:

I'm sure you're aware of this already, but just in case you want it regardless: It crashed when I was running for my life, (like the brave and courageous hero that I am) and entered an area where bears could spawn.

RayTrace082 commented 2 years ago

The fix applied to the "death" and "hurt" sounds, where I avoid the problem by using a generic sound whenever one is undefined. Didn't do the same thing with "ambient" sounds, because there is no generic ambient sounds, and it never gave any problems

It was my impression that the "ambient" sounds were handled differently and accounted for the chance that the sound was null, but clearly that's not the case. Pretty easy to fix however

Rakadeja commented 2 years ago

We're just about to delete the mod until it updates again. This crash has everyone disappointed on our server since there are so many nice, ambient mobs. Would greatly appreciate a fix for this! (1.18.2)